Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing array header include #1771

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

When stack trace is enabled we would run into compile failures since array.h wasn't explicitly included. We only work currently due to other headers bringing this include in.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Dec 19, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner December 19, 2024 14:45
@github-actions github-actions bot added the cpp Pertains to C++ code label Dec 19, 2024
@bdice
Copy link
Contributor

bdice commented Dec 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3bf6026 into rapidsai:branch-25.02 Dec 19, 2024
60 of 61 checks passed
@robertmaynard robertmaynard deleted the bug/add_missing_include branch December 19, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants