Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ignored cuda-python deprecation warning. #1768

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Remove ignored cuda-python deprecation warning. #1768

merged 2 commits into from
Dec 17, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 16, 2024

Description

Following #1756, we no longer need to guard against this deprecation warning.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner December 16, 2024 22:51
@bdice bdice requested a review from KyleFromNVIDIA December 16, 2024 22:51
@github-actions github-actions bot added the Python Related to RMM Python API label Dec 16, 2024
@bdice bdice changed the title Remove cuda-python deprecation warning. Remove ignored cuda-python deprecation warning. Dec 16, 2024
@bdice bdice assigned bdice and unassigned bdice Dec 16, 2024
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Dec 16, 2024
@vyasr
Copy link
Contributor

vyasr commented Dec 17, 2024

We're still importing it directly in our tests 😂

@bdice bdice requested a review from a team as a code owner December 17, 2024 01:36
@bdice
Copy link
Contributor Author

bdice commented Dec 17, 2024

Weird. I'm not sure how that slipped past me, I thought I had searched thoroughly. It should be fixed in 8afcc13.

@bdice
Copy link
Contributor Author

bdice commented Dec 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit a83c2ea into rapidsai:branch-25.02 Dec 17, 2024
57 of 58 checks passed
@jameslamb jameslamb removed the request for review from KyleFromNVIDIA December 17, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees

@bdice bdice

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @vyasr @jameslamb @Matt711