devcontainer improvements
#423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bdice
reviewed
Dec 11, 2024
bdice
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently testing #417 locally and I realized that the
devcontainertakes a long time to build.I had committed some
devcontainerimprovements to #358, but since that may not be merged for a while, I decided to open a separate PR for those changes to get them merged sooner.Effectively, this PR just moves tool installations (e.g. Go, Python, jq, yq, etc.) to a Dockerfile instead of using
devcontainerfeatures. This results in thedevcontainerimage building faster since the features generally do things like compile Python from source.To test these changes, I ran a few commands, including
./scripts/get_medium.py. That script pulled in the latest Medium posts, which I decided to also include in this PR.