Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate env prod vs dev keys usage #6255

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Conversation

jinchung
Copy link
Member

@jinchung jinchung commented Nov 6, 2024

Related to APP-2008

What changed (plus any additional context for devs)

Screen recordings / screenshots

Screenshot 2024-11-07 at 11 36 52 AM Screenshot 2024-11-07 at 11 37 12 AM Screenshot 2024-11-07 at 11 37 24 AM Screenshot 2024-11-07 at 11 37 36 AM

What to test

  • wallet data still behaves as expected
  • NFT related data (mints, offers, nft metadata) looks the same

Copy link

linear bot commented Nov 6, 2024

@jinchung jinchung marked this pull request as draft November 7, 2024 15:59
@jinchung jinchung marked this pull request as ready for review November 7, 2024 16:43
@jinchung jinchung requested review from benisgold and walmat November 7, 2024 16:43
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question: Why do we alias some env vars inside env.ts and not some others? One example in this PR is RESERVOIR_API_KEY

@brunobar79
Copy link
Member

Launch in simulator or device for 74e7f59

@jinchung
Copy link
Member Author

jinchung commented Nov 7, 2024

LGTM. One question: Why do we alias some env vars inside env.ts and not some others? One example in this PR is RESERVOIR_API_KEY

I think it started off with the IS_PROD vs not and some were added there in order to distinguish between PROD vs STAGING envs and expose them. Now that we don't need to do that for the RESERVOIR key, I'll follow up in another cleanup PR and remove the instances that use the env.ts for it.

@brunobar79
Copy link
Member

Launch in simulator or device for 3da66cc

@jinchung jinchung marked this pull request as draft November 19, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants