Updating Promenade keyboard (Missing keys in matrix, other minor changes to keymap) #24705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making changes suggested by zvecr. Removed dynamic_layer indicator, updated copyright year, deleted unused layers in keymaps. Co-authored-by: Joel Challis <[email protected]>
…hortcuts to Promenade layouts
Move WS2812 Driver from rules.mk to info.json Co-authored-by: jack <[email protected]>
Move WS2812 Driver from rules.mk to info.json Co-authored-by: jack <[email protected]>
Move WS2812 Driver from rules.mk to info.json Co-authored-by: jack <[email protected]>
Adding Promenade RP24S keyboard.json, default keymap, and readme
Adding layer access to layers 1 and 2
The Promenade supports the installation of either four 1.5u center column keys or six 1u keys. Initially, the matrix diagram, LAYOUT_ALL in keyboard.json, and keymap.c were configured only for the four 1.5u keys. These files have now been updated to include the 1u key option. Additionally, minor adjustments were made to the default keymap to reflect the most common layouts for this board. For example, KC_BSLS replaced KC_QUOT for the key located below Backspace. Practical features, such as adding a UG_TOGG key to the FN layer, were also implemented. Minor cosmetic updates were made to the layout visuals in the keymap as well.
Feags
changed the title
Feags
changed the title
waffle87
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Promenade supports the installation of either four 1.5u center column keys or six 1u keys. The
matrix_diagram.md, LAYOUT_ALL inkeyboard.json, andkeymap.care currently configured only for the four 1.5u keys. These files have now been updated to include the 1u key option.Additionally, minor adjustments were made to the default keymap to reflect the most common layouts for this board. For example,
KC_BSLSreplacedKC_QUOTfor the key located below Backspace. AUG_TOGGkey was added to the FN layer for practicality. In addition to changing the 1.5u center column to 1u, minor cosmetic updates were made to the layout visuals in the keymap.Types of Changes
Issues Fixed or Closed by This PR
Checklist