Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mod Mmm PCB #23836

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Add Mod Mmm PCB #23836

wants to merge 42 commits into from

Conversation

dcpedit
Copy link
Contributor

@dcpedit dcpedit commented May 31, 2024

Description

This adds support for the Mod Mmm PCB which is a replacement PCB for the IBM Model M. It comes in two variants: standard staggered layout, and ortholinear layout. Project is open source and can be found on GitHub: https://github.com/dcpedit/mod-mmm

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support dependencies labels May 31, 2024
keyboards/dcpedit/modmmm/info.json Outdated Show resolved Hide resolved
keyboards/dcpedit/modmmm/mcuconf.h Outdated Show resolved Hide resolved
keyboards/dcpedit/modmmm/config.h Outdated Show resolved Hide resolved
lib/chibios-contrib Outdated Show resolved Hide resolved
keyboards/dcpedit/modmmm/standard/rules.mk Outdated Show resolved Hide resolved
keyboards/dcpedit/modmmm/rules.mk Outdated Show resolved Hide resolved
keyboards/dcpedit/modmmm/ortho/rules.mk Outdated Show resolved Hide resolved
keyboards/dcpedit/modmmm/ortho/info.json Outdated Show resolved Hide resolved
keyboards/dcpedit/modmmm/standard/info.json Outdated Show resolved Hide resolved
@dcpedit
Copy link
Contributor Author

dcpedit commented May 31, 2024

The firmware no longer compiles when I remove rules.mk. I get the following error:

make dcpedit/modmmm/standard:via      
QMK Firmware 0.23.9
make: *** No rule to make target 'dcpedit/modmmm/standard:via'. Stop.

I also get the following error when I rename info.json to keyboard.json:

make dcpedit/modmmm/standard:via
QMK Firmware 0.23.9
☒ dcpedit/modmmm/standard: No LAYOUTs defined! Need at least one layout defined in info.json.
Making dcpedit/modmmm/standard with keymap via

@dunk2k
Copy link
Contributor

dunk2k commented Jun 1, 2024

QMK Repo version, on your local repository, is out of date - please update.

Regarding rules.mk and info.json > keyboard.json, build markers have changed as of #23293
This changes means:

  1. rules.mk is no longer used to denote which directory level firmware is built from
  2. keyboard.json is used to denote which directory to build firmware from, info.json is used to populate keyboard information directory level(s) above keyboard.json

@dunk2k
Copy link
Contributor

dunk2k commented Jun 1, 2024

@dcpedit
Please can PR Checklist guidance be followed regarding PCBs with multiple physical layouts

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 27, 2024
@dcpedit
Copy link
Contributor Author

dcpedit commented Jul 30, 2024

Waiting for review

@github-actions github-actions bot added core documentation python cli qmk cli command CI dd Data Driven Changes and removed stale Issues or pull requests that have become inactive without resolution. labels Jul 31, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Sep 20, 2024
@drashna drashna requested a review from a team October 11, 2024 03:30
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Via keymaps need to be removed.

keyboards/dcpedit/modmmm/config.h Outdated Show resolved Hide resolved
keyboards/dcpedit/modmmm/info.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 12, 2024
@dcpedit
Copy link
Contributor Author

dcpedit commented Oct 15, 2024

Via keymaps need to be removed.

@fauxpark I'm not sure I understand. Isn't keymap.json needed when I compile for VIA?

UPDATE: Nevermind, I found the PR that addresses the change. I've removed the VIA keymaps.

Copy link

github-actions bot commented Dec 7, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 7, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI cli qmk cli command core dd Data Driven Changes documentation keyboard keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants