-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Add yetis keyboard #22535
base: master
Are you sure you want to change the base?
Conversation
Please read and digest the PR Checklist as there are several aspects of this PR that need addressing, that are covered by this. |
3ccc6af
to
5f45d0d
Compare
fixed some issues, ptal For |
5f45d0d
to
2c54547
Compare
dace86a
to
4b08d75
Compare
d0afe4d
to
f6351ad
Compare
The current version fails to compile because:
What is missing or done wrong? |
Can you please take an another look? |
1259f25
to
83cfae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current state of the microcontroller/pin configuration is invalid. You have two choices
- Configure the keyboard to use an AVR microcontroller and include no converter logic (but be able to use it at will on your own)
"development_board": "elite_c",
"matrix_pins": {
"direct": {
// avr pin definitions
}
}
// other avr pin definitions...
- Configure the keyboard to use an RP2040 microcontroller and omit the possibility of using a converter to a different microcontroller (eg. stemcell)
"development_board": "elite_pi",
"matrix_pins": {
"direct": {
// rp2040 pin definitions
}
}
// other rp2040 pin definitions...
I chose to go with elite_c, the PR was updated accordingly. |
817de10
to
db8218a
Compare
I've updated the link and the picture. Can you please take a look @waffle87? |
All comments are resolved. Please let me know what are the next steps. |
56926b5
to
8e43c9b
Compare
8e43c9b
to
c853c1c
Compare
ping |
"enabled": true, | ||
"matrix_pins": { | ||
"right": { | ||
"direct": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is identical but flipped to the left/main config?
If that's the case, you don't actually need this block, and you can switch the column order for the right half in the layout section below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how can I do it. Can you please explain in more detail?
Thank you for your contribution! |
c853c1c
to
d8409f6
Compare
The yeti truly exists! Signed-off-by: Norbert Pocs <[email protected]>
d8409f6
to
4167a13
Compare
The yeti truly exists!
Adding a new keyboard named yetis.
Description
No other changes than adding a new kbd.
Types of Changes
Issues Fixed or Closed by This PR
Checklist