Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add yetis keyboard #22535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Keyboard] Add yetis keyboard #22535

wants to merge 1 commit into from

Conversation

jogme
Copy link

@jogme jogme commented Nov 23, 2023

The yeti truly exists!

Adding a new keyboard named yetis.

Description

No other changes than adding a new kbd.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added invalid pr_checklist_pending Needs changes as per the PR checklist labels Nov 23, 2023
@keyboard-magpie
Copy link
Contributor

Please read and digest the PR Checklist as there are several aspects of this PR that need addressing, that are covered by this.

@jogme
Copy link
Author

jogme commented Nov 24, 2023

fixed some issues, ptal

For <keyboard>.c should contain oled definitions - I have them in the keymap .c file, because it reads the key state of the modifier keys and could not do that without putting the functionality there. Any recommendation is welcomed.

@jogme jogme changed the title [Keyboard] Add yeti keyboard [Keyboard] Add yetis keyboard Nov 25, 2023
keyboards/yetis/config.h Outdated Show resolved Hide resolved
keyboards/yetis/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/yetis/readme.md Outdated Show resolved Hide resolved
keyboards/yetis/readme.md Outdated Show resolved Hide resolved
keyboards/yetis/rules.mk Outdated Show resolved Hide resolved
keyboards/yetis/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@jogme jogme force-pushed the yetis-keyboard branch 2 times, most recently from dace86a to 4b08d75 Compare December 14, 2023 17:05
keyboards/yetis/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/yetis/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/yetis/keymaps/jogme/keymap.c Outdated Show resolved Hide resolved
keyboards/yetis/readme.md Outdated Show resolved Hide resolved
keyboards/yetis/info.json Outdated Show resolved Hide resolved
keyboards/yetis/info.json Outdated Show resolved Hide resolved
keyboards/yetis/rules.mk Outdated Show resolved Hide resolved
keyboards/yetis/yetis.c Show resolved Hide resolved
keyboards/yetis/yetis.h Outdated Show resolved Hide resolved
keyboards/yetis/yetis.c Outdated Show resolved Hide resolved
@jogme jogme force-pushed the yetis-keyboard branch 2 times, most recently from d0afe4d to f6351ad Compare December 14, 2023 18:29
@jogme
Copy link
Author

jogme commented Dec 14, 2023

The current version fails to compile because:

Compiling: platforms/chibios/drivers/serial.c                                                      platforms/chibios/drivers/serial.c: In function 'Thread1':
platforms/chibios/drivers/serial.c:90:9: error: implicit declaration of function 'palWaitLineTimeout' [-Werror=implicit-function-declaration]
   90 |         palWaitLineTimeout(SOFT_SERIAL_PIN, TIME_INFINITE);
      |         ^~~~~~~~~~~~~~~~~~
platforms/chibios/drivers/serial.c: In function 'soft_serial_target_init':
platforms/chibios/drivers/serial.c:103:5: error: implicit declaration of function 'palEnablePadEvent' [-Werror=implicit-function-declaration]
  103 |     palEnablePadEvent(PAL_PORT(SOFT_SERIAL_PIN), PAL_PAD(SOFT_SERIAL_PIN), PAL_EVENT_MODE_FALLING_EDGE);

What is missing or done wrong?

keyboards/yetis/rules.mk Outdated Show resolved Hide resolved
keyboards/yetis/info.json Outdated Show resolved Hide resolved
keyboards/yetis/keymaps/jogme/keymap.c Outdated Show resolved Hide resolved
keyboards/yetis/keymaps/jogme/keymap.c Outdated Show resolved Hide resolved
@jogme
Copy link
Author

jogme commented Feb 5, 2024

Can you please take an another look?

@jogme jogme force-pushed the yetis-keyboard branch 2 times, most recently from 1259f25 to 83cfae0 Compare February 11, 2024 18:07
@jogme
Copy link
Author

jogme commented Mar 19, 2024

The requested changes were made, is this PR in a good shape now? @drashna @waffle87 @sigprof

Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current state of the microcontroller/pin configuration is invalid. You have two choices

  • Configure the keyboard to use an AVR microcontroller and include no converter logic (but be able to use it at will on your own)
"development_board": "elite_c",
"matrix_pins": {
    "direct": {
        // avr pin definitions
    }
}
// other avr pin definitions...
  • Configure the keyboard to use an RP2040 microcontroller and omit the possibility of using a converter to a different microcontroller (eg. stemcell)
"development_board": "elite_pi",
"matrix_pins": {
    "direct": {
        // rp2040 pin definitions
    }
}
// other rp2040 pin definitions...

keyboards/yetis/config.h Outdated Show resolved Hide resolved
keyboards/yetis/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/yetis/readme.md Outdated Show resolved Hide resolved
keyboards/yetis/rules.mk Outdated Show resolved Hide resolved
keyboards/yetis/yetis.c Outdated Show resolved Hide resolved
keyboards/yetis/yetis.c Outdated Show resolved Hide resolved
@jogme
Copy link
Author

jogme commented Mar 27, 2024

The current state of the microcontroller/pin configuration is invalid. You have two choices

* Configure the keyboard to use an AVR microcontroller and include no converter logic (but be able to use it at will on your own)
"development_board": "elite_c",
"matrix_pins": {
    "direct": {
        // avr pin definitions
    }
}
// other avr pin definitions...
* Configure the keyboard to use an RP2040 microcontroller and omit the possibility of using a converter to a different microcontroller (eg. stemcell)
"development_board": "elite_pi",
"matrix_pins": {
    "direct": {
        // rp2040 pin definitions
    }
}
// other rp2040 pin definitions...

I chose to go with elite_c, the PR was updated accordingly.

@jogme jogme force-pushed the yetis-keyboard branch 2 times, most recently from 817de10 to db8218a Compare March 28, 2024 16:52
@jogme jogme force-pushed the yetis-keyboard branch from 7f9ba0b to d23dc97 Compare May 24, 2024 09:18
@jogme
Copy link
Author

jogme commented May 24, 2024

I've updated the link and the picture. Can you please take a look @waffle87?

@jogme jogme force-pushed the yetis-keyboard branch from d23dc97 to 6339bd6 Compare July 6, 2024 10:19
@jogme
Copy link
Author

jogme commented Jul 6, 2024

All comments are resolved. Please let me know what are the next steps.

keyboards/yetis/config.h Outdated Show resolved Hide resolved
keyboards/yetis/yetis.c Show resolved Hide resolved
keyboards/yetis/rules.mk Outdated Show resolved Hide resolved
@github-actions github-actions bot added the core label Jul 15, 2024
@jogme jogme force-pushed the yetis-keyboard branch 2 times, most recently from 56926b5 to 8e43c9b Compare August 10, 2024 16:00
@jogme
Copy link
Author

jogme commented Oct 20, 2024

ping

@drashna drashna removed invalid pr_checklist_pending Needs changes as per the PR checklist labels Oct 25, 2024
"enabled": true,
"matrix_pins": {
"right": {
"direct": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is identical but flipped to the left/main config?
If that's the case, you don't actually need this block, and you can switch the column order for the right half in the layout section below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how can I do it. Can you please explain in more detail?

keyboards/yetis/yetis.c Outdated Show resolved Hide resolved
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 10, 2024
The yeti truly exists!

Signed-off-by: Norbert Pocs <[email protected]>
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants