Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Add Web App manifest to allow standalone usage #21980

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lightswitch05
Copy link

@lightswitch05 lightswitch05 commented Dec 10, 2024

Why

I love the WebUI and use it regularly on multiple devices. I've installed it on my homepage of my iPhone so it looks like an app of its own - but it just opens in the browser when I click on it. I would like it to function less like another webpage that opens in a browser tab, and more like a app of its own with its own window.

What

To get an app-like feel, all that is needed in a little manifest.json file. So I add that file in this PR. I've tried my best to match the existing logic - adding it to the auto formatter and (hopefully) getting translation working correctly. I don't expect this PR to be approved and merged without some discussion of its merits - but hopefully this gets the ball rolling and we can see where it ends up.

Testing

I'm using a mac... I was able to get a successful run of the build commands, but when I try to actually open the app, it just crashes. I think I might not have everything setup correctly with Qt. So... unfortunately that means this PR is fully untested. If there are any docs I can read, please let me know. Otherwise, maybe this PR will still be useful for a discussion if this feature is even wanted by the project or not. I tried searching in advanced, and I couldn't find any similar requests.

@glassez glassez requested a review from a team December 11, 2024 17:00
@glassez glassez added the WebUI WebUI-related issues/changes label Dec 11, 2024
@glassez glassez added this to the 5.1 milestone Dec 11, 2024
@Chocobo1
Copy link
Member

I love the WebUI and use it regularly on multiple devices.

Does the WebUI really work well on non-desktop devices? Do you mind taking a screenshot?

So... unfortunately that means this PR is fully untested. If there are any docs I can read, please let me know.

For development purpose, you can use the "alternative WebUI" function and let it point to your local src/webui/www folder. It should pick up any changes you made in that folder.

Co-authored-by: Chocobo1 <[email protected]>
@lightswitch05
Copy link
Author

I won't say it's an ideal experience, but it works fine on mobile! I would never try messing with configurations, but for simple torrent management functions, it's very convenient. It's easy to load it up, paste in a torrent URL, and go on with my day. Or maybe just load it up and see if that low-seed torrent ever completed.imageimageimage

@Chocobo1 Chocobo1 removed this from the 5.1 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants