Feat/watchpoints #13248
Open
Feat/watchpoints #13248
+160
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
bzoracler
commented
Dec 14, 2024
| _Identifier: TypeAlias = str | ||
|
|
||
| class Watch: | ||
| custom_printer: Callable[[Any], None] | None |
There was a problem hiding this comment.
Several callback types this package have Any as argument type(s), which are assigned with user-defined callbacks. I avoided using object here to be compatible with user-defined callbacks, which may annotate the parameters with more precise types.
- Printer callbacks: accepts any object and writes to a stream
- Compare (
cmp) callbacks: Accepts any 2 objects and compare their equality copy: Makes a copy of any objectwhencallbacks: Inspect/trace/watch an objectwhena condition is fulfilled; takes any object and outputs abool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete set of stubs for the watchpoints package (GitHub: https://github.com/gaogaotiantian/watchpoints).
Even though it seems like activity is low, it still gets ~800 downloads a week, and its lowish numbers are due to it being a debugging tool rather than a dependency library.
Its stated Python support ranges (3.6-3.10) are modest - I've run the tests locally on Python 3.13-dev and they pass without any modifications.
The intended API and types were inferred through the implementation and the README.