Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _GeneratorContextManagerBase.__init__ #13246

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Dec 14, 2024

I think that #6676 showed that Paramspec didn't work, but that wasn't actually the fault of _GeneratorContextManagerBase.

We'll see what mypy-primer has to say about it.

I think that python#6676 showed that Paramspec didn't work, but that
wasn't actually the fault of _GeneratorContextManagerBase.
@tungol tungol force-pushed the _GeneratorContextManagerBase branch from b4acb0e to bf795a1 Compare December 14, 2024 03:11
@tungol tungol marked this pull request as draft December 14, 2024 03:12
@tungol tungol closed this Dec 14, 2024

This comment has been minimized.

@tungol tungol reopened this Dec 14, 2024

This comment has been minimized.

This comment has been minimized.

@tungol tungol marked this pull request as ready for review December 14, 2024 05:23

This comment has been minimized.

@tungol
Copy link
Contributor Author

tungol commented Dec 14, 2024

Ah, well, that's no good then.

@tungol tungol force-pushed the _GeneratorContextManagerBase branch from ca85887 to 01ee3d5 Compare December 14, 2024 07:19

This comment has been minimized.

Co-authored-by: Jelle Zijlstra <[email protected]>
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pyinstrument (https://github.com/joerick/pyinstrument)
- pyinstrument/vendor/decorator.py:295: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], tuple[Any, ...], dict[str, Any]], None]")  [assignment]
+ pyinstrument/vendor/decorator.py:295: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManagerBase[_G], Callable[..., _G], tuple[Any, ...], dict[str, Any]], None]")  [assignment]
- pyinstrument/vendor/decorator.py:301: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], tuple[Any, ...], dict[str, Any]], None]")  [assignment]
+ pyinstrument/vendor/decorator.py:301: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManagerBase[_G], Callable[..., _G], tuple[Any, ...], dict[str, Any]], None]")  [assignment]

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/server/database/configurations.py:263: error: Return type "_AsyncGeneratorContextManager[Any]" of "begin_transaction" incompatible with return type "Coroutine[Any, Any, Any]" in supertype "BaseDatabaseConfiguration"  [override]
+ src/prefect/server/database/configurations.py:263: error: Return type "_AsyncGeneratorContextManager[Any, None]" of "begin_transaction" incompatible with return type "Coroutine[Any, Any, Any]" in supertype "BaseDatabaseConfiguration"  [override]
- src/prefect/server/database/configurations.py:448: error: Return type "_AsyncGeneratorContextManager[Any]" of "begin_transaction" incompatible with return type "Coroutine[Any, Any, Any]" in supertype "BaseDatabaseConfiguration"  [override]
+ src/prefect/server/database/configurations.py:448: error: Return type "_AsyncGeneratorContextManager[Any, None]" of "begin_transaction" incompatible with return type "Coroutine[Any, Any, Any]" in supertype "BaseDatabaseConfiguration"  [override]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants