-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add _GeneratorContextManagerBase.__init__
#13246
Open
tungol
wants to merge
6
commits into
python:main
Choose a base branch
from
tungol:_GeneratorContextManagerBase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that python#6676 showed that Paramspec didn't work, but that wasn't actually the fault of _GeneratorContextManagerBase.
tungol
force-pushed
the
_GeneratorContextManagerBase
branch
from
December 14, 2024 03:11
b4acb0e
to
bf795a1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ah, well, that's no good then. |
tungol
force-pushed
the
_GeneratorContextManagerBase
branch
from
December 14, 2024 07:19
ca85887
to
01ee3d5
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jelle Zijlstra <[email protected]>
Diff from mypy_primer, showing the effect of this PR on open source code: pyinstrument (https://github.com/joerick/pyinstrument)
- pyinstrument/vendor/decorator.py:295: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], tuple[Any, ...], dict[str, Any]], None]") [assignment]
+ pyinstrument/vendor/decorator.py:295: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManagerBase[_G], Callable[..., _G], tuple[Any, ...], dict[str, Any]], None]") [assignment]
- pyinstrument/vendor/decorator.py:301: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], tuple[Any, ...], dict[str, Any]], None]") [assignment]
+ pyinstrument/vendor/decorator.py:301: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManagerBase[_G], Callable[..., _G], tuple[Any, ...], dict[str, Any]], None]") [assignment]
prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/server/database/configurations.py:263: error: Return type "_AsyncGeneratorContextManager[Any]" of "begin_transaction" incompatible with return type "Coroutine[Any, Any, Any]" in supertype "BaseDatabaseConfiguration" [override]
+ src/prefect/server/database/configurations.py:263: error: Return type "_AsyncGeneratorContextManager[Any, None]" of "begin_transaction" incompatible with return type "Coroutine[Any, Any, Any]" in supertype "BaseDatabaseConfiguration" [override]
- src/prefect/server/database/configurations.py:448: error: Return type "_AsyncGeneratorContextManager[Any]" of "begin_transaction" incompatible with return type "Coroutine[Any, Any, Any]" in supertype "BaseDatabaseConfiguration" [override]
+ src/prefect/server/database/configurations.py:448: error: Return type "_AsyncGeneratorContextManager[Any, None]" of "begin_transaction" incompatible with return type "Coroutine[Any, Any, Any]" in supertype "BaseDatabaseConfiguration" [override]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that #6676 showed that Paramspec didn't work, but that wasn't actually the fault of
_GeneratorContextManagerBase
.We'll see what mypy-primer has to say about it.