fix(dns): update boto pkg blocks with new onedir install method #538
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
reviewed
Dec 17, 2024
ewdurbin
approved these changes
Dec 17, 2024
ewdurbin
reviewed
Dec 17, 2024
|
|
||
| {% set public_ipv4 = salt["mine.get"]("*", "public_ipv4") %} | ||
|
|
||
| # We assume that a server will always have an IPv4 address. | ||
|
|
||
| # TODO: Update back to boto3_route53 when https://github.com/saltstack/salt/pull/60951 makes it into a release | ||
| # TODO(@JacobCoffee): Update back to boto3_route53 |
There was a problem hiding this comment.
I don't recall why boto3 is preferred, but this is the diff that originally moved us back to just both: 4ebb9fd
There was a problem hiding this comment.
iirc from reading boto3 was the automagically generated thing from the AWS spec whereas boto was done by hand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pip, since old method is no longer being able to be installed due to forced salt version updatesCloses
Closes #536