Lint: Normalise whitespace #4078
Conversation
|
Yup, this is probably okay! |
|
I'm less keen on the more explicit lists: realistically, we're unlikely to fill in any of the gaps for older numbers. I'm leaning more towards just applying the fixes to all files in one fell swoop. |
Same. I say we bite the bullet and just do it everywhere. |
|
@lysnikolaou YOLO |
| name: "Ensure files end with a single newline" | ||
| - id: trailing-whitespace | ||
| name: "Remove trailing whitespace" | ||
| args: ["--chars", " \t"] |
There was a problem hiding this comment.
Why only trim trailing spaces and tabs? What trailing whitespace do we want to conserve?
https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#trailing-whitespace
There was a problem hiding this comment.
Form-feed characters before the emacs stanza in older PEPs. I'd want to remove the stanzas and the form-feed characters at the same time.
There was a problem hiding this comment.
Shall we do it in this PR? How many extra files and pings would it be?
There was a problem hiding this comment.
~290 files (searching for " Local Variables:") Currently this PR touches 90 files.
There was a problem hiding this comment.
My thinking with #4081 was to include 'everything' in one PR, so we don't do a mass ping again (or, try and minimise the number of mass pings). It's a fine line, though.
cc @lysnikolaou (illustation of #4067)
📚 Documentation preview 📚: https://pep-previews--4078.org.readthedocs.build/