-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message for incompatible TypeVar value #3707
Improve error message for incompatible TypeVar value #3707
Conversation
@JukkaL what do you think of the updated error message? |
Looks reasonable! Here's another alternative that would make the error message perhaps even clearer:
It may also make sense to special case
|
Both sounds good! Regarding the first suggestion though, I think there might be a case where specifying type argument number is useful (when names of two type args are the same). |
@ilevkivskyi I will get back to it this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
And agreed -- the |
Fixes #3341