Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128116: Skip test_socket VSOCK testStream() on PermissionError #128120

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 20, 2024

@vstinner
Copy link
Member Author

!buildbot PPC64LE Fedora Stable PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit e587ce5 🤖

The command will test the builders whose names match following regular expression: PPC64LE Fedora Stable PR

The builders matched are:

  • PPC64LE Fedora Stable PR

@vstinner
Copy link
Member Author

I only found two lines in Linux net/vmw_vsock/ using EACCES, both in "bind" operations:

Example:

	if (port <= LAST_RESERVED_PORT && !capable(CAP_NET_BIND_SERVICE))
		return -EACCES;

But the Python test uses port 1234 which is greater than LAST_RESERVED_PORT (1023).

@vstinner vstinner merged commit cbfe302 into python:main Dec 20, 2024
45 checks passed
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vstinner vstinner deleted the vsock_eperm branch December 20, 2024 12:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2024

GH-128123 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 20, 2024
@vstinner vstinner added the needs backport to 3.12 bug and security fixes label Dec 20, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2024

GH-128124 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 20, 2024
vstinner added a commit that referenced this pull request Dec 20, 2024
…ror (GH-128120) (#128123)

gh-128116: Skip test_socket VSOCK testStream() on PermissionError (GH-128120)
(cherry picked from commit cbfe302)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Dec 20, 2024
…ror (GH-128120) (#128124)

gh-128116: Skip test_socket VSOCK testStream() on PermissionError (GH-128120)
(cherry picked from commit cbfe302)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants