-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128136: Possibility to customize hardcoded xml declaration #128095
Closed
+70
−3
Closed
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1f00810
Update ElementTree.py
pprossi 9b3d903
Update ElementTree.py
pprossi dd0553f
Merge branch 'main' into pprossi-patch-elementtree2
pprossi b7967ae
Update test_xml_etree.py
pprossi b90f905
Update test_xml_etree.py
pprossi 82eee7b
Merge branch 'python:main' into pprossi-patch-elementtree2
pprossi b90b81e
📜🤖 Added by blurb_it.
blurb-it[bot] 6018922
Update 2024-12-20-18-54-53.gh-issue-128136.tgbvWt.rst
pprossi 52bc8df
Update 2024-12-20-18-54-53.gh-issue-128136.tgbvWt.rst
pprossi 5b15a7e
Update 2024-12-20-18-54-53.gh-issue-128136.tgbvWt.rst
pprossi f1235b5
Merge branch 'main' into pprossi-patch-elementtree2
pprossi d8a2300
Update ElementTree.py
pprossi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
Misc/NEWS.d/next/Library/2024-12-20-18-54-53.gh-issue-128136.tgbvWt.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
New parameter added to the write function that allows you to customize the xml declaration, which was previously hard-coded. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I mentioned, the NEWS entry must be shorter (one sentence in general). |
||
The standard functionality is retained; if you don't specify the xml_declaration_definition parameter, the previous standard declaration is used. ``<?xml version='1.0' encoding='{encoding}'?>`` | ||
When specifying the parameter, the following options are available. | ||
E.g.: | ||
tree.write(file, encoding="utf-8", xml_declaration=True, xml_declaration_definition='''<?xml version="{version}" encoding="{encoding}"?>''') | ||
tree.write(file, encoding="utf-8", xml_declaration=True, xml_declaration_definition='''<?xml version="1.1" encoding="{encoding}"?>''') | ||
tree.write(file, encoding="utf-8", xml_declaration=True, xml_declaration_definition='''<?xml version="1.1"?>''') | ||
The placeholders {version} and {encoding} are replaced, version is always 1.0 and enconding depends on the code as before. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should add a unit test to test it's behavior. Verify it whether the requirements are met.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some unit tests but there is'nt an issu to add an issue title.
and i think the change has little impact on Python users.