Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version #128090

Merged
merged 1 commit into from
Dec 19, 2024
Merged

gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version #128090

merged 1 commit into from
Dec 19, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 19, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 19, 2024
Open
@vstinner
Copy link
Member Author

@hugovk: I took the freedom of creating a PR from your branch to check if it fix #128069.

@vstinner
Copy link
Member Author

I confirm that the change fix #128069.

The macOS job was run with the macos-13 image version 20241216.479 which has the bug. The "Install Homebrew dependencies" step completed successfully.

skirpichev
skirpichev approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least this can be committed as a temporary fix.

@vstinner vstinner enabled auto-merge (squash) December 19, 2024 10:18
@vstinner vstinner merged commit 46dc1ba into python:main Dec 19, 2024
40 checks passed
@hugovk hugovk deleted the 3.14-brew-overwrite-tcl-tk branch December 19, 2024 12:26
@hugovk hugovk mentioned this pull request Dec 19, 2024
Closed
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Dec 19, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 19, 2024
@vstinner @hugovk @miss-islington
pythongh-128069: brew link --overwrite tcl-tk@8 to prevent conflict w…
2342a48 
…ith GitHub image's version (pythonGH-128090)

brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
(cherry picked from commit 46dc1ba)

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 19, 2024

GH-128096 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 19, 2024
vstinner added a commit that referenced this pull request Dec 19, 2024
@miss-islington @vstinner @hugovk
[3.13] gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict …
08f9b7c 
…with GitHub image's version (GH-128090) (#128096)

gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version (GH-128090)

brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
(cherry picked from commit 46dc1ba)

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@vstinner vstinner added the needs backport to 3.12 bug and security fixes label Dec 20, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2024
@vstinner @hugovk @miss-islington
pythongh-128069: brew link --overwrite tcl-tk@8 to prevent conflict w…
065753f 
…ith GitHub image's version (pythonGH-128090)

brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
(cherry picked from commit 46dc1ba)

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 20, 2024

GH-128125 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 20, 2024
vstinner added a commit that referenced this pull request Dec 20, 2024
@miss-islington @vstinner @hugovk
[3.12] gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict …
825b83d 
…with GitHub image's version (GH-128090) (#128125)

gh-128069: brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version (GH-128090)

brew link --overwrite tcl-tk@8 to prevent conflict with GitHub image's version
(cherry picked from commit 46dc1ba)

Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @skirpichev @hugovk