Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PyPy nightly runs #2952

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Feb 12, 2024

Reference: #2885

This was mentioned elsewhere recently cause they're kinda flakey (nightly means that pypy problems become our problems)

@A5rocks A5rocks mentioned this pull request Feb 12, 2024
17 tasks
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f071c06) 99.64% compared to head (ccb7fa0) 99.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2952   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         117      117           
  Lines       17564    17564           
  Branches     3166     3166           
=======================================
  Hits        17502    17502           
  Misses         43       43           
  Partials       19       19           

@jakkdl
Copy link
Member

jakkdl commented Feb 12, 2024

any reason not to run pypy-3.9 and/or pypy-3.10 on Mac instead?

edit: ah, I see you added it as a bullet point in #2885

Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pypy flakiness is not fun

@A5rocks A5rocks merged commit adee8f6 into python-trio:master Feb 13, 2024
27 of 28 checks passed
@A5rocks A5rocks deleted the remove-pypy-nightly branch February 13, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants