Always create virtual env if virtualenvs.force-create is True

[jasondamour]

Pull Request Check List

Resolves: #4055

• Added tests for changed code.
• Updated documentation for changed code.

[radoering]

As it is implemented, when virtualenvs.force-create is set:

• Poetry still uses an existing in-project .venv (and does not create a new venv) if virtualenvs.in-project is not set to false. That is probably fine.
• If virtualenvs.create is set to false, the system env will be used. No venv will be created. Not sure if that makes sense.

@finswimmer Pinging you since you have done some refactoring of the env management recently. What do you think of such an option, especially in combination with the existing options, cf #4055 (comment).

As an alternative to a new option we could also allow the value "force" for virtualenvs.create. Then, we do not have to think about combinations like virtualenvs.create = false and virtualenvs.force-create = true.

After having decided what exactly this option should look like, we definitively need some tests and docs.

[jasondamour]

@radoering thanks for the quick (weekend) review! I agree with you on everything.

As an alternative to a new option we could also allow the value "force" for virtualenvs.create.

I thought about this too, and decided against it to make it appear "safer*" to merge. But if the maintainers agree with it, I prefer "force" as a value too, and I'll implement that instead.

Additionally, I would like to see this released in 1.X, is there anything I need to do regarding the branch to do that?

[radoering]

Additionally, I would like to see this released in 1.X, is there anything I need to do regarding the branch to do that?

There are no plans for another 1.X feature release.