Add build config settings to core #715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
2 tasks
I think, we are open for this setting. Please also create a downstream (draft) PR that shows the usage of this setting. (You can replace the poetry-core dependency with a git dependency pointing to your branch in a temporary commit that will be dropped before merging.) |
radoering
requested changes
Apr 1, 2024
|
Yes.
…On Mon, Apr 1, 2024, 5:09 AM Randy Döring ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I suppose, this setting is relevant for all types of dependencies because
it's not just relevant for directories but also for sdists?
—
Reply to this email directly, view it on GitHub
<#715 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMUJYRLHL4LPQMM3BMR3Y3EP3BAVCNFSM6AAAAABFLAEW42VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZQHE2TCNJSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hello @earonesty |
|
I never finished the other side of it. This PR is complete from what I can
tell
…On Wed, Jun 26, 2024, 12:03 PM Igor Sadchenko ***@***.***> wrote:
Hello @earonesty <https://github.com/earonesty>
Any updates here?
Maybe do you need help with this PR?
—
Reply to this email directly, view it on GitHub
<#715 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMUMFEAIT5N33ZHSVRN3ZJMF6PAVCNFSM6AAAAABFLAEW42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSGQZTSMJQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build() function takes optional config-settings which can be useful for building gpu-specific packages, editable-mode settings for setuptools, or other build-tool specific configurations. If used, should resolve a number of issues. For example: python-poetry/poetry#8909
(Sorry for the million commits, im editing this in a browser.)
See: https://build.pypa.io/en/stable/api.html. Typing matches that.
If there's no objections, will finish adding tests, etc.