-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration via lsp guide to README #78
Add configuration via lsp guide to README #78
Conversation
This is editor dependent, is it not? |
Yes it will be editor depedendent, I guess I was mainly trying to address that AFAICS the README config section doesn't mention that configuration from LSP is supported at all.
I'm happy to drop the example. How about doing something similar to https://github.com/python-lsp/python-lsp-server/blob/develop/CONFIGURATION.md by sticking the configuration options in a table with the relevant configuration keys? e.g.:
etc |
@LaurenceWarne do you know how to handle overrides? pylsp_mypy = {
enabled = true,
overrides = {"--python-executable", "python"},
} But if I configure it through |
Ok, just figured out on my own: pylsp_mypy = {
enabled = true,
overrides = {"--python-executable", "python", true},
} You have to add the @Richardk2n is this expected behavior? |
@LaurenceWarne This seems sensible to me. @nramirezuy The |
c30b69d
to
c72e536
Compare
👍 I've made edits to the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make the short summary in every description bold.
c72e536
to
03b30dc
Compare
I think I've addressed everything 👍 |
Alter README configuration documentation to be a table similar to https://github.com/python-lsp/python-lsp-server/blob/develop/CONFIGURATION.md with the addition that it includes the names of LSP configuration keys.
03b30dc
to
7b64c74
Compare
@Richardk2n sorry I never came back to you, I meant setting the executable from So my configuration ended up like this, which I think should be the default, since it works with pyenv and venv. I'm not looking to start a discussion on a closed ticket, but I'm happy to be @ in a new ticket about the subject. |
Hi, this PR is in response to #32, I've added a description for how the plugin can be configured (to the best of my understanding 🙂) using lsp, and given an example similar to that given in https://github.com/python-lsp/python-lsp-ruff#configuration.
Thanks!