Allow infinite retry #396
Merged
Allow infinite retry #396
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows values like `float('inf')` to retry infinite. This can be useful in cluster contexts where a redis service might temporarily not available for some reason but you might not want the worker to crash on that but waiting until redis is available again
Update connections.py
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 11 11
Lines 1052 1052
Branches 199 199
=======================================
Hits 1038 1038
Misses 6 6
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
rossmacarthur
pushed a commit
to hunchdata/arq
that referenced
this pull request
Sep 19, 2023
|
thanks so much. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some contexts (cluster) it is useful to allow infinite retries
float('inf'). Especially in clusters redis might be not available for some time but we don't want the worker to crash on that. Instead it just should wait until redis comes available again.float('inf')always compare greater than any float or int. So it should be safe to use. Butstr(float('inf'))translates to'inf'and that's why this change is necessary.