-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redis pipeline created and not used #374
Fix redis pipeline created and not used #374
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 98.64% 98.76% +0.12%
==========================================
Files 9 11 +2
Lines 957 1050 +93
Branches 179 198 +19
==========================================
+ Hits 944 1037 +93
Misses 6 6
Partials 7 7
Continue to review full report at Codecov.
|
LGTM, thanks so much. |
Hello, it is chance for new release with this fix? I updated to latest 0.25 and this update leads to random fake ResultNotFound errors (proabably race condition because I use 0.01 poll_delay). |
@JonasKs do you think we can do a new release? I can help with it on Tuesday hopefully. (Once we have the first alpha of pydantic v2 out) |
Yes! 😊 I'll look over all PRs tomorrow and see if there's some issues I can resolve. I'm available all week. 😊 |
Amazing, thank you. |
Hello, any progress on this? :-) Thank you! |
Hi friends, we're also hitting spurious/transient Wondering if there's a recommended workaround and/or rough timeline for the next release fixing this? All the best |
FWIW, I added the following in my
A release would be appreciated |
It seems you are looking for a quick roundtrip. I find myself in a similar situation and I am wondering if there would be a more resource friendly solution than this "spin loop", using pubsub (possibly with keyspace notifications) on one end and using one of the blocking redis functions (block until a job is is waiting). |
+1. A new release with this fix would be appreciated. |
Any plan on a bugfix release @samuelcolvin ? I think we are also getting the JobNotFound error after upgrading to 0.25. |
|
Fixes a mistake introduced in #364 where a Redis pipeline was created but not used (ArqRedis is used directly).
The pipeline was there to prevent race conditions, so it should be used.