-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent worker getting stuck in terminating state #370
Conversation
…not updated correctly
…obs is set to False. close python-arq#369
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 98.74% 98.64% -0.11%
==========================================
Files 9 9
Lines 957 957
Branches 179 179
==========================================
- Hits 945 944 -1
Misses 6 6
- Partials 6 7 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't have time right now to dig deep into this.
@mernmic can you confirm if this fixes your problem?
@JonasKs @samuelcolvin yes this has fixed the issue. thanks! |
Anything else, or shall we create a patch release? |
This addresses any issues we've been seeing, although there is one other approved PR. |
Thanks @samuelcolvin, sorry for the mess. |
No problem, no one makes more mess than I do 😄. |
|
First commit proves the bug (see the pipeline failures here)
Second commit contains the fix.
Closes #369