Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent worker getting stuck in terminating state #370

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

JonasKs
Copy link
Collaborator

@JonasKs JonasKs commented Dec 6, 2022

First commit proves the bug (see the pipeline failures here)
Second commit contains the fix.

Closes #369

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #370 (c9959ac) into main (b6dda0e) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   98.74%   98.64%   -0.11%     
==========================================
  Files           9        9              
  Lines         957      957              
  Branches      179      179              
==========================================
- Hits          945      944       -1     
  Misses          6        6              
- Partials        6        7       +1     
Impacted Files Coverage Δ
arq/worker.py 99.16% <100.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6dda0e...c9959ac. Read the comment docs.

@samuelcolvin samuelcolvin changed the title fix #369 Prevent worker getting stuck in terminating state Dec 6, 2022
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't have time right now to dig deep into this.

@mernmic can you confirm if this fixes your problem?

@mernmic
Copy link
Contributor

mernmic commented Dec 6, 2022

LGTM, but I don't have time right now to dig deep into this.

@mernmic can you confirm if this fixes your problem?

@JonasKs @samuelcolvin yes this has fixed the issue. thanks!

@samuelcolvin samuelcolvin merged commit 430df07 into python-arq:main Dec 6, 2022
@samuelcolvin
Copy link
Member

Anything else, or shall we create a patch release?

@mernmic
Copy link
Contributor

mernmic commented Dec 6, 2022

Anything else, or shall we create a patch release?

This addresses any issues we've been seeing, although there is one other approved PR.
We'll more than happily further test the patch once released.

@JonasKs
Copy link
Collaborator Author

JonasKs commented Dec 6, 2022

Thanks @samuelcolvin, sorry for the mess.

@samuelcolvin
Copy link
Member

No problem, no one makes more mess than I do 😄.

@samuelcolvin
Copy link
Member

v0.26.0b1 is released, please try it, I'll release v0.26 at the end of the week, see #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants