chore: remove py dependency #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandre35
force-pushed
the
amuller/remove_py_dep
branch
from
dddeb79 to
621d53c
Compare
| source_attrs = {"src": video.get("video"), "type": "video/mp4"} | ||
| return str(html.video(html.source(**source_attrs), **video_attrs)) | ||
| return ( | ||
| f'<video controls="" play-pause-on-click="" poster="{video.get("image")}" style="border:1px solid #e6e6e6;' |
There was a problem hiding this comment.
This is missing safe quoting off the inputs
sandre35
force-pushed
the
amuller/remove_py_dep
branch
from
621d53c to
59c8665
Compare
|
Looks good! Please also add an entry to the changelog. 🙏 |
|
Please also add a shoutout to the person reporting the issue and to yourself for fixing it. 😊 |
sandre35
force-pushed
the
amuller/remove_py_dep
branch
from
8c2e865 to
7f92fb0
Compare
|
Not sure why the tests are failing. Can you take a look? |
sandre35
force-pushed
the
amuller/remove_py_dep
branch
from
7f92fb0 to
f96722b
Compare
|
Context path of the docker-compose file was incorrect. Fixed! |
sandre35
force-pushed
the
amuller/remove_py_dep
branch
from
f96722b to
fa5d02c
Compare
|
@BeyondEvil After having a look at failing tests, the cause is the release of selenium package. Changes are linked to this issue #283 Can we merge this PR and proceed to the 4.0.2 release ? |
sandre35
force-pushed
the
amuller/remove_py_dep
branch
from
fa5d02c to
965bd12
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue: #313