Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserstack test status #306

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ankit098
Copy link
Contributor

  • Updating marking session status code:
    -> Removed extra attempts to mark status
    -> Use javascript executor before session quit rather than making a rest api call after session end for visibility on dashboard.
  • Minor update to getting username/key to ignore if values in conf file if they are sample/default values.

remove multiple api calls, use driver to execute js to mark status for better annotation on browserstack dashboard
ignore username/key from config file if those are default values and pick from env variables if available
@Ankit098 Ankit098 force-pushed the bstack_session_status branch from a35a06c to 583a4d3 Compare November 20, 2022 14:35
@BeyondEvil
Copy link
Contributor

Thank you for this PR! Much appreciated! 🙏

I will hold off on merging it until the changes we have pending re Selenium4 has been merged.

@Ankit098
Copy link
Contributor Author

Ankit098 commented Dec 1, 2022

Hey, @BeyondEvil do we have an ETA for the changes to be merged?

@Ankit098
Copy link
Contributor Author

ping @BeyondEvil ..

@BeyondEvil
Copy link
Contributor

ping @BeyondEvil ..

Thanks for pinging!

I've been superbusy, will try to get to this ASAP tho.

@Ankit098
Copy link
Contributor Author

@BeyondEvil bump for this..

@Ankit098
Copy link
Contributor Author

bump^ any updates on this?

@BeyondEvil
Copy link
Contributor

bump^ any updates on this?

Hey, sorry for not getting to this yet. 😓

I’m still working on the rewrite and release of the next major release of pytest-html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants