Make aiosmtpd dependency optional

[mgorny]

Move the aiosmtpd dependency to "smtp" extra, and handle the lack of it
gracefully in tests. The aiosmtpd package is no longer maintained
and had major bugs that lead to it being queued for removal from Gentoo.
FWICS all packages in Gentoo that are using pytest-localserver are only
using the HTTP support.

[mgorny]

BTW I've seen you considering removing it entirely in aio-libs/aiosmtpd#144 — I don't mind either way.

[diazona]

Sorry I didn't reply earlier, I was away with limited internet access. Anyway, thanks for the change! I was also considering doing something like this when I switched to aiosmtpd, but I guess I decided against it because I figured it would be less disruptive to people's workflows not to have to specify an extra to get the same functionality that was there before. Or something. I don't quite remember now, and in retrospect it probably doesn't make all that much sense 😆

Anyway, bottom line, I am on board with this. 👍 I suppose we might as well keep the smtp functionality as an extra since people won't be getting it by default, so it doesn't hurt to just have it there for now. It would be nice to change tox.ini to run tests both with and without the smtp extra, but if you don't want to add that now, I can do it in another PR later.

Is there any urgent need on Gentoo's behalf to get out a new version that includes this PR? I see that you patched the ebuild to remove the aiosmtpd dependency so I'm guessing this can wait for a while, e.g. for the 0.7 release, but I can make another release sooner if necessary.

[mgorny]

Anyway, bottom line, I am on board with this. +1 I suppose we might as well keep the smtp functionality as an extra since people won't be getting it by default, so it doesn't hurt to just have it there for now. It would be nice to change tox.ini to run tests both with and without the smtp extra, but if you don't want to add that now, I can do it in another PR later.

Done that. I've permitted myself to update the obsolete py.test names with pytest too, and to remove tox-gh-actions since it only made all the config a few times longer. Now both tox and GHA cover up to py3.11 + pypy3, and GHA runs py and py-smtp tox envs which correspond to the selected interpreter.

Is there any urgent need on Gentoo's behalf to get out a new version that includes this PR? I see that you patched the ebuild to remove the aiosmtpd dependency so I'm guessing this can wait for a while, e.g. for the 0.7 release, but I can make another release sooner if necessary.

No. no urgent need. Thanks!

[diazona]

Thanks! Just a couple suggestions, and then I do want to wait a few more days in case any of the other maintainers have comments; otherwise I'll merge this later this week.

[diazona]

Let me ping @redtoad in case he has any comments, since he's the one who originally added the Github Actions config.

[diazona]

BTW @mgorny I just noticed the ebuild for pytest-localserver-0.7.0 still uses the patch in src_prepare, which shouldn't be needed anymore, I think? I'd be willing to submit a request to change the ebuild through the proper channels if that would be best, but I'm not set up to do so easily.