Add pre-commit to run codespell and other tools #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
pre-commit
branch
6 times, most recently
from
69fd7ca to
d2b4b3b
Compare
mattip
reviewed
Aug 30, 2024
| # - id: end-of-file-fixer | ||
| # - id: fix-encoding-pragma | ||
| # - id: no-commit-to-branch | ||
| # - id: trailing-whitespace |
There was a problem hiding this comment.
I am not a pre-commit expert. Does enabling these hooks install the corresponding packages?
There was a problem hiding this comment.
These are Python files that are installed as a single package. Each file is less than 5k. Commenting merely determines if they are run or not.
https://github.com/pre-commit/pre-commit-hooks/tree/main/pre_commit_hooks
mattip
reviewed
Aug 30, 2024
mattip
reviewed
Aug 30, 2024
|
Can we close this now that #137 is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the https://pre-commit.com tool to set up localhost and GitHub Actions testing of codespell and other tools.
Enable some standard hooks while leaving others commented out to facilitate enabling them in future pull requests.
Migrate the codespell settings into
pyproject.tomland add hooks for validation and formatting of this file.https://github.com/pre-commit-ci/lite-action is used to run the tests on pull requests. https://pre-commit.ci does more.