Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interp na warning #9813

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Interp na warning #9813

wants to merge 2 commits into from

Conversation

hollymandel
Copy link
Contributor

@hollymandel hollymandel mentioned this pull request Nov 24, 2024
Closed
5 tasks
dcherian
dcherian reviewed Dec 2, 2024
View reviewed changes
xarray/core/dataset.py
@@ -4184,6 +4184,12 @@ def _validate_interp_indexer(x, new_x):
variables: dict[Hashable, Variable] = {}
reindex: bool = False
for name, var in obj._variables.items():
if var.isnull().any():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah we can't do this really. I thought the behaviour stemmed from NaNs in the coordinate. Scanning the whole array like this is going to be expensive in many cases.

@dcherian
Copy link
Contributor

dcherian commented Dec 2, 2024

Let's close if there are no other ideas, scanning the whole array for NaNs could be quite expensive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistent 1D interp on 1D and ND DataArrays with NaNs
2 participants
@hollymandel @dcherian