-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add active status and indicate archived #540
base: main
Are you sure you want to change the base?
Conversation
@@ -52,6 +52,9 @@ <h3 class="card__title no_toc" itemprop="headline"> | |||
<!-- TODO: Create and use sunpy.html here --> | |||
<li><a href="communities/astropy.html"><i class="fa-solid fa-check-double"></i> <img src="http://img.shields.io/badge/Affiliated-SunPy-yellow.svg?style=flat" alt="SunPy" /></a></li> | |||
{% endif %} | |||
{% if apackage.active == false %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@banesullivan this is a good start.
What we should do here since we only have 1 archived packages is create a new section at the bottom of that page that says .
## Archived packages
Archived packages are packages that have successfully completed [pyOpenSci's software peer review process](https://www.pyopensci.org/about-peer-review/index.html) but are no longer maintained. [Check out our software maintenance policy for how we determine when a package becomes archived.](https://www.pyopensci.org/software-peer-review/our-process/policies.html#package-maintenance-and-maintainer-responsiveness)
then create a for loop using jekyll / liquid that grabs those packages. Rather than a card, let's list them with the package name and a link to the review for now.
that way, we aren't modifying the package-grid template. We are just adding a new section and listing archived pages. in the future, they may live on a separate page, but for now, let's list them at the bottom without a card.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @banesullivan please rebase this pr against main
I left one comment to address - let's move archived packages to a separate section on the packages page.
many thanks! this is a great start and the logic is working well! 🚀
I don't want to lose this, but we should add a sentence in two sections of our peer review guide. i've opened a issue here |
Indicate when a package has been marked as "archived" (or inactive) per pyOpenSci/pyosMeta#242