Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active status and indicate archived #540

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

banesullivan
Copy link

Indicate when a package has been marked as "archived" (or inactive) per pyOpenSci/pyosMeta#242

@@ -52,6 +52,9 @@ <h3 class="card__title no_toc" itemprop="headline">
<!-- TODO: Create and use sunpy.html here -->
<li><a href="communities/astropy.html"><i class="fa-solid fa-check-double"></i> <img src="http://img.shields.io/badge/Affiliated-SunPy-yellow.svg?style=flat" alt="SunPy" /></a></li>
{% endif %}
{% if apackage.active == false %}
Copy link
Member

@lwasser lwasser Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banesullivan this is a good start.

https://output.circle-artifacts.com/output/job/9350867b-9505-4a09-b082-a278c9751dd3/artifacts/0/_site/python-packages.html

What we should do here since we only have 1 archived packages is create a new section at the bottom of that page that says .

## Archived packages 
Archived packages are packages that have successfully completed [pyOpenSci's software peer review process](https://www.pyopensci.org/about-peer-review/index.html) but are no longer maintained. [Check out our software maintenance policy for how we determine when a package becomes archived.](https://www.pyopensci.org/software-peer-review/our-process/policies.html#package-maintenance-and-maintainer-responsiveness)

then create a for loop using jekyll / liquid that grabs those packages. Rather than a card, let's list them with the package name and a link to the review for now.

that way, we aren't modifying the package-grid template. We are just adding a new section and listing archived pages. in the future, they may live on a separate page, but for now, let's list them at the bottom without a card.

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @banesullivan please rebase this pr against main

I left one comment to address - let's move archived packages to a separate section on the packages page.

many thanks! this is a great start and the logic is working well! 🚀

@lwasser
Copy link
Member

lwasser commented Dec 18, 2024

I don't want to lose this, but we should add a sentence in two sections of our peer review guide. i've opened a issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants