Skip to content

Commit

Permalink
Fix coverage upload (#923)
Browse files Browse the repository at this point in the history
A breaking change to the upload-artifact GitHub Action has broken uploading coverage files (not only for us, see actions/upload-artifact#614) and has not been reverted. This change will fix that by enabling hidden files only for those uploads.

Signed-off-by: Keith Battocchi <[email protected]>
  • Loading branch information
kbattocchi authored Oct 11, 2024
1 parent 960c0dd commit fae5f72
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,9 @@ jobs:
if: success() || failure() && contains(fromJSON('["success", "failure"]'), steps.run_tests.outcome)
with:
name: coverage-${{ env.id_string }}
path: .coverage.${{ env.id_string }}
path: .coverage.${{ env.id_string }}
# need to include hidden files since path starts with .
include-hidden-files: true
- name: Make test XML filename unique
run: mv junit/test-results.xml ${{ env.id_string }}-test-results.xml
# Run whether or not the tests passed, but only if they ran at all
Expand Down Expand Up @@ -278,6 +280,8 @@ jobs:
with:
name: coverage-${{ env.id_string }}
path: .coverage.${{ env.id_string }}
# need to include hidden files since path starts with .
include-hidden-files: true
- name: Make test XML filename unique
run: mv junit/test-results.xml ${{ env.id_string }}-test-results.xml
# Run whether or not the tests passed, but only if they ran at all
Expand Down

0 comments on commit fae5f72

Please sign in to comment.