Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added home link on 404 page #515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

praveen-rikhari
Copy link

@praveen-rikhari praveen-rikhari commented Feb 20, 2024

Description

Now you can see back to home page link on the 404 page

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for processing-faf822 ready!

Name Link
🔨 Latest commit f5e475a
🔍 Latest deploy log https://app.netlify.com/sites/processing-faf822/deploys/65d4d2ff81179e000891cd14
😎 Deploy Preview https://deploy-preview-515--processing-faf822.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@praveen-rikhari praveen-rikhari force-pushed the praveen/fix-404-page-with-home-link branch from 2501969 to f5e475a Compare February 20, 2024 16:27
@SableRaf SableRaf requested a review from Stefterv July 12, 2024 11:49
@SableRaf
Copy link
Collaborator

@Stefterv Since you were recently looking at the 404 page maybe you'll have some thoughts about this one.

Copy link
Contributor

@Stefterv Stefterv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good apart from the unnecessarily added package
The language/content probably needs some work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a Spanish translation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary ?

@@ -136,6 +136,7 @@
"inUse": "In use",
"notFound": "NOT FOUND",
"notFoundText": "You just hit a route that doesn't exist... the sadness.",
"backToHome": "back to home",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalisation?

@SableRaf
Copy link
Collaborator

@praveen-rikhari If you're still interested in this PR, could you take a look at the comments above? Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants