-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added home link on 404 page #515
base: main
Are you sure you want to change the base?
added home link on 404 page #515
Conversation
✅ Deploy Preview for processing-faf822 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2501969
to
f5e475a
Compare
@Stefterv Since you were recently looking at the 404 page maybe you'll have some thoughts about this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good apart from the unnecessarily added package
The language/content probably needs some work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a Spanish translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary ?
@@ -136,6 +136,7 @@ | |||
"inUse": "In use", | |||
"notFound": "NOT FOUND", | |||
"notFoundText": "You just hit a route that doesn't exist... the sadness.", | |||
"backToHome": "back to home", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalisation?
@praveen-rikhari If you're still interested in this PR, could you take a look at the comments above? Thank you for your contribution! |
Description
Now you can see back to home page link on the 404 page