Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue #3280 #3288

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Harshit-7373
Copy link

@Harshit-7373 Harshit-7373 commented Dec 1, 2024

"npm run test" failing inside docker just after cloning the project #3280.

github-Harshit-7373

Fixes #issue-number

Changes:

  1. After i run "npm run test" , it didn't run and showed that the jest command is not recognized.
  2. I updated the jest dependencies to the latest and then run "npm run test"
  3. It successfully runned without any issue , in the test status it showed 23 passed and total were 23.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

"npm run test" failing inside docker just after cloning the project processing#3280.

github-Harshit-7373
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

I'm running the tests within my Docker environment with the Jest upgrade to 27.5.1 and am still running into my tests failing. Would you be able to provide more screenshots or a demonstrative video of how you're running it? Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, screenshots that help show an issue's resolution should be attached to the PR's description rather than as a folder within the codebase. It'd be great if you could remove this folder and screenshot and add the screenshot instead into your PR's description!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be great if you could note any major changes you think are important to be aware of between version 27.3.1 to 27.5.1!

Copy link
Author

@Harshit-7373 Harshit-7373 Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually , There are many issues that end up because of the version not been updated to up to date. And that is why i was thinking to modify the .env file and create a prebuild function before running the project where that javascript function will control the version control system. If the version differs in some or the other way , it can automatically run it , upgrade the version upto date so that unnecessary issues are not created . Need some views on this , if you could help me out. Also there is a way , to resolve this version issue using docker.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, screenshots that help show an issue's resolution should be attached to the PR's description rather than as a folder within the codebase. It'd be great if you could remove this folder and screenshot and add the screenshot instead into your PR's description!

Yes , I removed that folder , I understood my mistake and i can assure you this will not happen in the upcoming days.

@Harshit-7373
Copy link
Author

Thanks for your work on this!

I'm running the tests within my Docker environment with the Jest upgrade to 27.5.1 and am still running into my tests failing. Would you be able to provide more screenshots or a demonstrative video of how you're running it? Thanks!

Sure , Just give me some time i will surely help you solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants