UI changes on Private sketch feature

[vivekbopaliya]

Progress on #3034

Changes:

• Design inspired by this figma design

bandicam.2024-05-04.13-33-34-726.mp4

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[release-com]

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

• p5.js-web-editor
  • app-ted1322.release.editor.p5js.org/
  • preview-ted1322.release.editor.p5js.org/

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-272e3cc59b

[raclim]

Thanks @vivekbopaliya! I'll try to have an in-depth look at this by early next week!

[vivekbopaliya]

@raclim just wanted to ping you a real quick that i updated the test cases that were failing!

[raclim]

@vivekbopaliya Thanks so much for checking in on this, I'm sorry that it took a while to get back to this!

I loaded this up on my local environment and I think functionality-wise this looks super amazing so far!!! 🎉

One thing I noticed that the state of the "Private" checkbox on the editor sometimes doesn't align with the toggle on the /sketches page until it's refreshed (demonstrated in video below). This isn't a major issue at all, but I think this could be a potential source of confusion for some users.

Screen.Recording.2024-05-29.at.1.25.09.PM.mov

I also think some of the changes in this PR includes some that have already been merged into the develop branch. Would you be able to change the branch this PR is merging to be develop instead of processing:feat/privatesketch?

[vivekbopaliya]

Oops! How did I overlook this? Sure, I will try to fix it and merge it into the develop branch.

[raclim]

Sorry I think deleting the processing:feat/privatesketch branch ended up closing this PR! 😭 I don't think I can reopen this on my end, but this should be resolved once you make a new one to develop. Sorry again about this!

[vivekbopaliya]

Hi @raclim,

Haha no worries! You can consider the old PR now. I pushed the updates to the old PR, and it is now up to date with the develop branch.

PS: I tried solving the bug. When a user switches a project from private to public( from sketch collection toggle ), it updates on the homepage. However, it does not change in other cases. A third person might catch the bug if they look into it, but for now... :(

bandicam.2024-06-01.16-04-33-170.mp4

[raclim]

@vivekbopaliya Thanks so much for being flexible and adapting! I'll check out the other PR that you just updated :)

Also thanks for looking into the bug! I feel like it's not a major issue, so I think might be fine to leave and have addressed in the future for now!

Just a heads up, I'll be merging in a few older PRs that might cause some merge conflicts, but I'll try to make a shareable staging environment of what's currently there so other folks can test it out without having to load it locally as well! I'll update the PR with a URL of the environment once that's done!