Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change test parameterization layout #274

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HerrMuellerluedenscheid
Copy link
Contributor

@priv-kweihmann I'd like to refactor the test parameterization which I find hard to read, which is e.g. because keys and values are on the same indentation level they take a lot of vertical space. What do you think about this more compact style? Also this avoids indentation of the provided strings. The tripple quoted strings would have to be left-aligned to not have the precending tabs.

@priv-kweihmann
Copy link
Owner

I get your pain with the current parametrization... unfortunately I hadn't had an idea how to write in a better way, whilst keeping the flexibility of just writing key value pairs (filename, content).

I'm open to ideas - your change so far does feel a bit like moving things right to left, while I more and more come to the conclusion that it may need a more fundamental restructuring.

Actually I would suggest to document a test style guide first and make that one enforceable. Otherwise this could turn into a neverending story

@HerrMuellerluedenscheid
Copy link
Contributor Author

After our todays call, I'll provide an example how the parameterisation might be further improvided by removing redundancy with a method that prepares test inputs or a dedicated fixture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants