[SelectPanel] Improve messages API

[camertron]

What are you trying to accomplish?

Now that we've decided on a messages API for the PRC SelectPanel, I thought it was time to dust off this old PR and implement the new API for PVC as well.

Screenshots

There should be no perceivable visual changes.

Integration

Yes. We will need to migrate existing usages of the no_results_label argument and the error_content and preload_ error_content slots. no_results_label should be straightforward to identify using primer-query, and a quick search should show us where with_error_content and with_preload_error_content are being used.

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

• Fixes axe scan violation - This change fixes an existing axe scan violation.
• No new axe scan violation - This change does not introduce any new axe scan violations.
• New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 16d1847

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

[camertron]

Waiting to merge this until the next release. The current one is getting pretty big and this PR will require some prod changes.

[lesliecdubs]

@camertron how can we ensure this gets into the next release? I see we shipped PVC ~4 days ago and this wasn't included.

[camertron]

Hey @lesliecdubs 👋 I avoided merging this PR on purpose 😄 In my previous comment, I said:

Waiting to merge this until the next release. The current one is getting pretty big and this PR will require some prod changes.

Should be able to get it out in the next release.

[lesliecdubs]

@camertron thanks, I did see that note but noticed several releases had gone out since that time. I see you are the current release conductor so I'll let you take it from here, assuming this will go out before your rotation ends!

[camertron]

Ah yeah, v0.35.0 and v0.35.1 actually went out together because v0.35.1 fixed an issue in v0.35.0 (plus brought a few other changes along for the ride). So, we technically only shipped a single release 😓

Sadly I also am not shipping this PR in the release going out today because I didn't feel like I had the bandwidth to update the necessary callsites in dotcom 😢

[lesliecdubs]

@camertron thanks for letting me know. Is there anything I can do to help with prioritization / make space for getting this out in the next release, including dotcom integration?

[camertron]

@lesliecdubs perhaps we could make some room for this and PRC SelectPanel fixes after the primerize work has been wrapped up?

[lesliecdubs]

@camertron please check in when primerize wraps and we can confirm, but I think both this and the PRC SelectPanel fixes are likely worth prioritizing next!