fix #77: prettier-js cleanse the code #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See the issue #77
Brief Analysis
After debugging the procedure, it is found that the
call-process
callsprettier
with arguments with outputting to temporary files before doing patching. Original implementation is to input code content toprettier
via standard input, however somehow it does not work under win11/powershell. When putting the code file as argument, the reformat is working (e.g.prettier xxx.js
).Test Coverage
Only tested on Win11. Environment can be found in issue #77 as well.