Skip to content

Commit

Permalink
Update flask-appbuilder authlib/oauth dependency (apache#24516)
Browse files Browse the repository at this point in the history
The dependency we have for flask-appbuilder oauth authentication
(for github/google authentication) should follow the limits
that flask-appbuilder current version has. We added authlib there
but apparently FAB currently limits authlib to <= 1.0 - we should
follow fab rather than have our own dependency here.

This has been pointed out in
dpgaspar/Flask-AppBuilder#1861
  • Loading branch information
potiuk authored Jun 19, 2022
1 parent 9a3e1e4 commit 5674491
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
facebook = [
'facebook-business>=6.0.2',
]
flask_appbuilder_authlib = [
'authlib',
flask_appbuilder_oauth = [
'flask-appbuilder[oauth]',
]
github = [
'pygithub',
Expand Down Expand Up @@ -767,8 +767,8 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'cncf.kubernetes': kubernetes, # also has provider, but it extends the core with the KubernetesExecutor
'dask': dask,
'deprecated_api': deprecated_api,
'github_enterprise': flask_appbuilder_authlib,
'google_auth': flask_appbuilder_authlib,
'github_enterprise': flask_appbuilder_oauth,
'google_auth': flask_appbuilder_oauth,
'kerberos': kerberos,
'ldap': ldap,
'leveldb': leveldb,
Expand Down

0 comments on commit 5674491

Please sign in to comment.