Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy settings #4049

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Update mypy settings #4049

merged 1 commit into from
Jul 17, 2022

Conversation

stinodego
Copy link
Member

Relates to #4044

This update prepares more strict type checking by mypy.

Changes:

  • Enabled some strictness flags that we already comply to.
  • Added commented-out strictness flags that we want to comply to in the future, and added TODO comments.
  • Enabled namespace_packages, which makes sure files will get checked even if they do not fall below an __init__.py file. See here for more information on this. This does not directly impact polars at this moment, but avoids nasty surprises in the future.

@github-actions github-actions bot added the python Related to Python Polars label Jul 17, 2022
@ritchie46
Copy link
Member

CI is happy, so merging it in. Thanks.

@ritchie46 ritchie46 merged commit 6e1a7b1 into pola-rs:master Jul 17, 2022
@stinodego stinodego deleted the strict-mypy branch July 25, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants