Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Core] Rename the Fisherman actor to Watcher #967

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0xRampey
Copy link

@0xRampey 0xRampey commented Aug 3, 2023

Description

This PR renames all occurrences of the 'Fisherman' actor to 'Watcher'.

Avoiding reviewpad since there are too many changes

Issue

Fixes the first deliverable from #956

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other (Refactor)

List of changes

  • Renamed all instances of Fishermen
  • Recomputed hardcoded test values like state hashes and session IDs.

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@0xRampey 0xRampey added core Core infrastructure - protocol related core starter task Good for newcomers, but aimed at core team members though still open for everyone large Pull request is large labels Aug 3, 2023
@0xRampey 0xRampey requested review from Olshansk and dylanlott August 3, 2023 21:56
@0xRampey 0xRampey self-assigned this Aug 3, 2023
@reviewpad
Copy link

reviewpad bot commented Aug 3, 2023

Thank you @0xRampey for this first contribution!

@Olshansk
Copy link
Member

Olshansk commented Aug 7, 2023

@0xRampey Please resolve conflicts with main and let us know when this is no longer a WIP. If it's a WIP, should still be a draft.

@0xRampey 0xRampey marked this pull request as draft August 7, 2023 18:31
@0xRampey 0xRampey mentioned this pull request Aug 8, 2023
13 tasks
@0xRampey
Copy link
Author

0xRampey commented Aug 8, 2023

Waiting on #972 to be merged to run k8s localnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core starter task Good for newcomers, but aimed at core team members though still open for everyone core Core infrastructure - protocol related large Pull request is large
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants