Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: react to config changes #6395

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: react to config changes #6395

wants to merge 4 commits into from

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 14, 2022

Fixes #6394.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Dec 14, 2022
@alexcjohnson
Copy link
Collaborator

Nice! Maybe then just a test like this one but for cartesian?

it('can put polar plots into staticPlot mode', function(done) {

@archmoj
Copy link
Contributor Author

archmoj commented Dec 21, 2022

@alexcjohnson I don't recall what noCIdep was about. ¯\_(ツ)_/¯
After the changes proposed in this PR, it looks like we need to adjust the cartesian test right above the line you mentioned.

@alexcjohnson
Copy link
Collaborator

@noCIdep came in here: 623146f91c

    // Although not recommended, some tests "depend" on other
    // tests to pass (e.g. the Plotly.react tests check that
    // all available traces and transforms are tested). Tag these
    // with @noCIdep, so that
    // - $ npm run test-jasmine -- tags=noCI,noCIdep
    // can pass.

So looks like on CI it's ignored, but it marks tests that need to run so the noCI tests succeed. Quite possibly obsolete by now, you could try running just npm run test-jasmine -- tags=noCI and see if it works?

And good call, I somehow hadn't noticed the cartesian test right above that 😅 But that test was already passing, right? So what can we add to that test that would have broken before this change but now works correctly?

@gvwilson gvwilson self-assigned this May 27, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added fix fixes something broken P1 needed for current cycle and removed status: has TODOs bug something broken labels Aug 8, 2024
@gvwilson gvwilson added the cs customer success label Aug 21, 2024
@archmoj archmoj added this to the v3.0.0 milestone Oct 2, 2024
@archmoj archmoj modified the milestones: v3.0.0, v4.0.0 Nov 7, 2024
@archmoj archmoj added P3 backlog and removed P1 needed for current cycle labels Nov 7, 2024
@gvwilson gvwilson assigned gvwilson and unassigned archmoj Nov 20, 2024
@archmoj archmoj changed the title react to config changes Fix: react to config changes Nov 22, 2024
@archmoj archmoj assigned archmoj and unassigned gvwilson Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cs customer success fix fixes something broken P3 backlog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable updating the config of a plot without changing other parameters
3 participants