Fix apt-get lock held by another process error by retry #82
Conversation
pleskdistup/common/src/dpkg.py
Outdated
| cant_get_lock = True | ||
|
|
||
| cmd = ["apt-get", "dist-upgrade", "-y"] + APT_CHOOSE_OLD_FILES_OPTIONS | ||
| while True: |
There was a problem hiding this comment.
Can we use for interval in locked_sleep_intervals instead? This way, we can at least get rid of i and check for it
There was a problem hiding this comment.
Yes it's my first thought as well but locked_sleep_intervals could be empty which means no retry at all - so I needed do ... while() in python
There was a problem hiding this comment.
Perhaps we could use a retry decorator instead? We just need to find a way to include sleep 🤔
There was a problem hiding this comment.
Perhaps we should create our own simple decorator for this, as the default one does not support any delay.
There was a problem hiding this comment.
Yes maybe later. Our need is a bit different though: Feed the ("command") decorator with (possibly many) regexp/strings that the program might emit and designates temporary failure.
ukablan-wpc
force-pushed
the
plesk/ukablan/fix/PAUX-6388/retry_when_apt-get_fails_with_lock_err
branch
from
0911232 to
ec98698
Compare
ukablan-wpc
force-pushed
the
plesk/ukablan/fix/PAUX-6388/retry_when_apt-get_fails_with_lock_err
branch
from
173dc6b to
27a5864
Compare
ukablan-wpc
force-pushed
the
plesk/ukablan/fix/PAUX-6388/retry_when_apt-get_fails_with_lock_err
branch
from
eb39210 to
4360058
Compare
ukablan-wpc
changed the title
ukablan-wpc
deleted the
plesk/ukablan/fix/PAUX-6388/retry_when_apt-get_fails_with_lock_err
branch
Fixes PAUX-6388 Failed Upgrade - Could not get lock /var/cache/apt/archives/lock. It is held by process 37677 (python3)