Add an action to restart the plesk-firewalld service and disable the conflicting firewalld service #70
Conversation
| # Don't do startup because the services will be started up after reboot at the end of the script anyway. | ||
| return action.ActionResult() | ||
|
|
||
| def _revert_action(self) -> action.ActionResult: |
There was a problem hiding this comment.
Maybe remember initial firewalld state and restore it on revert too?
There was a problem hiding this comment.
It's not obvious, because firewalld and plesk-firewall are not meant to operate at the same time. If both are enabled, something is likely wrong.
On the other hand centos2alma was not designed to fix such issues by reverting operations. Therefore, it might be better to return the server to its original state, even if that state is incorrect 🤔
There was a problem hiding this comment.
I have checked it and found a problem. When we start firewalld during the revert process, we lose the SSH connection, causing the revert to stop. I suggest not starting firewalld during the revert.
There was a problem hiding this comment.
Ah, wait a moment. Plesk-firewall already performs the same function. Therefore, this approach may not be the best. I will need to revise the change
…vice is enabled These services conflict with each other, so we need to choose one. If plesk-firewall is enabled, we assume it has been chosen by the customer, so we keep it enabled
SandakovMM
force-pushed
the
disable-firewalld
branch
from
a9a921f to
1d17d29
Compare
No description provided.