Require cookie value to be string (unset omitted or null) #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #101.
This enforces string input as suggested by @dougwilson.
Two considerations:
String
constructor? I suggest no, as do Node. That is also what I went with in the PR.undefined
. But there are tests for expiring cookies usingnull
. What aboutfalse
? I feelundefined
andnull
should cover it (an explicitCookies.remove
would avoid ambiguity, see Add cookies.remove(name[, options]) method #98).