dev_quick_start_continue

How to start working on an issue?

• create a separate branch where you will be working on the issue. This branch should be based on the master branch:

  $ git checkout -b ghXXX_meaningful_name master

  where XXX is the issue number and meaningful_name is a short description of the issue.

• modify files that needed for the issue and create a commit

• run integration tests to ensure that you didn't break anything else

• push branch to the GitHub

• create Pull Request in the php-coder/mystamps repository:

  • open https://github.com/php-coder/mystamps/pulls
  • click on button "Create pull request"
  • fill the relevant fields
  • append Address to #XXX to the description where XXX is the issue number. Note that the format of this message is important! If you miss it, a bot will remind you :)

• check the report from TravisCI and fix possible errors from different tools for static analysis

• wait for a code review

• (optional) create more commits to fix comments after code review

• (optional) squash all the commits into one (and do git push --force-with-lease)