New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path to pants.log #134

Merged

benjyw merged 1 commit into pantsbuild:main from andrelegault:andre/fix-pants-log-path

Mar 15, 2024

Contributor

andrelegault commented Mar 14, 2024

The log file is in workdir, according to https://github.com/pantsbuild/pants/blob/44a06c5825e294757fb1dfe5920ea4b81db56023/src/python/pants/init/logging.py#L232 The path referred to in the docs is preceded by workdir: https://github.com/pantsbuild/pants/blob/44a06c5825e294757fb1dfe5920ea4b81db56023/docs/docs/using-pants/using-pants-in-ci.mdx#L240


          fix path to pants.log

d05f608

The log file is in workdir, according to https://github.com/pantsbuild/pants/blob/44a06c5825e294757fb1dfe5920ea4b81db56023/src/python/pants/init/logging.py#L232
The path referred to in the docs is preceded by workdir: https://github.com/pantsbuild/pants/blob/44a06c5825e294757fb1dfe5920ea4b81db56023/docs/docs/using-pants/using-pants-in-ci.mdx#L240

benjyw approved these changes

View reviewed changes

Contributor

benjyw left a comment

Thanks for the fix! The location of that file was changed in a recent release and we missed this location for updating.

benjyw merged commit f37c500 into pantsbuild:main

2 checks passed

Contributor

benjyw commented Mar 15, 2024

Thanks again @andrelegault!

andrelegault deleted the andre/fix-pants-log-path branch

March 16, 2024 20:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet