Feat/cleanup #913
Draft
Feat/cleanup #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
December 10, 2024 17:10
…s.total is not queried
ciaranschutte
commented
Dec 15, 2024
| @@ -26,7 +59,7 @@ export default ({ type, getServerSideFilter }) => { | |||
| nestedFieldNames, | |||
| filters: compileFilter({ | |||
| clientSideFilter: resolvedFilter, | |||
| serverSideFilter: getServerSideFilter(context), | |||
| serverSideFilter: getServerSideFilter(), | |||
There was a problem hiding this comment.
this doesn't appear to be needed? As far as I read, es client is only thing in context and the filter ops shouldn't be used directly in that. thoughts? - Jon, Justin @
ciaranschutte
force-pushed
the
feat/cleanup
branch
from
e26d4a1 to
7828313
Compare
tighten config resolver tighten config resolver
ciaranschutte
force-pushed
the
feat/cleanup
branch
from
7828313 to
0a61fb1
Compare
ciaranschutte
changed the base branch from
feature/federated_search
to
feat/multiple_threshold
added 7 commits
December 15, 2024 19:05
simplify network supported type lookup
setup, cleanup field querying setup, cleanup field querying
ciaranschutte
force-pushed
the
feat/cleanup
branch
from
e354ba1 to
074b775
Compare
fix resp
ciaranschutte
force-pushed
the
feat/cleanup
branch
from
7740fd2 to
edafe93
Compare
Base automatically changed from
feat/multiple_threshold
to
feature/federated_search
December 16, 2024 22:43
ciaranschutte
commented
Dec 16, 2024
Comment on lines
+1
to
+24
| import { Client } from '@elastic/elasticsearch'; | ||
| import { GraphQLResolveInfo } from 'graphql'; | ||
|
|
||
| export type Context = { | ||
| esClient: Client; | ||
| }; | ||
|
|
||
| export type ResolverOutput<T> = T | Promise<T>; | ||
|
|
||
| /** | ||
| * GQL resolver | ||
| * | ||
| * @param root The parent object of a query. | ||
| * @param args The query arguments. | ||
| * @param context The context passed to apollo-server for queries. | ||
| * @param info The GraphQL info object. | ||
| * @return Returns resolved value; | ||
| */ | ||
| export type Resolver<Root = {}, QueryArgs = Object, ReturnValue = undefined> = ( | ||
| root: Root, | ||
| args: QueryArgs, | ||
| context: Context, | ||
| info: GraphQLResolveInfo, | ||
| ) => ResolverOutput<ReturnValue> | ResolverOutput<ReturnValue>; |
There was a problem hiding this comment.
Add reusable GQL resolver type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createConnectionResolversas a top level TS file so everything below can be typedutilsfolder dump, created distinct files__typenamedistinction in network connected aggregations type, uses singular Aggregation type throughout