Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parsers configurable #1038

Closed
wants to merge 6 commits into from

Conversation

Aeliot-Tm
Copy link

@Aeliot-Tm Aeliot-Tm commented Jul 25, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Documented? yes
License MIT

Add possibility to configure parsers.
This is necessary for supporting of Apollo Federation Entities.

@Vincz
Copy link
Collaborator

Vincz commented Jul 25, 2022

Hi @Aeliot-Tm!
Parsing is something have been working on a few months back.
The idea was to handle it as proper Symfony services allowing to extend it using all the tools Symfony has to offer.
Unfortunately , I have been able to find the time to work on it but it was almost finished.
You can check the latest version here : https://github.com/vincz/GraphQLBundle
The various parsers were exploded into different packages (including under configuration/ in the repository).
If you have time to work on it, it would be the prefered way to go.

@Aeliot-Tm
Copy link
Author

Aeliot-Tm commented Jul 25, 2022

Hi @Vincz!
Thank you for information. I'll have a look.

@Aeliot-Tm Aeliot-Tm force-pushed the make_parsers_configurable branch from 112a078 to 556e1fb Compare July 25, 2022 21:44
@Aeliot-Tm
Copy link
Author

I created another more complex PR: #1040

@Aeliot-Tm Aeliot-Tm closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants