Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWE 1339 #697

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

CWE 1339 #697

wants to merge 26 commits into from

Conversation

BartyBoi1128
Copy link
Contributor

Documentation and code updates for CWE-1339 Insufficient Precision or Accuracy of a Real Number

BartyBoi1128 and others added 4 commits December 3, 2024 14:07
Added new noncomplian01.py

Signed-off-by: BartyBoi1128 <[email protected]>
Added new compliant01.py

Signed-off-by: BartyBoi1128 <[email protected]>
Added new compliant02.py

Signed-off-by: BartyBoi1128 <[email protected]>
Copy link
Contributor

@s19110 s19110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some minor cosmetic fixes. Other than that it looks good.

@myteron myteron self-requested a review December 5, 2024 13:25
Copy link
Contributor

@myteron myteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update main readme.md !

bunch of formatting and link issues

BartyBoi1128 and others added 17 commits December 11, 2024 11:24
Updated ISO/IEC reference link as previous looked like spam

Signed-off-by: BartyBoi1128 <[email protected]>
Updated output to "bash" and added blank line to please linter.

Signed-off-by: BartyBoi1128 <[email protected]>
Updated output of "text" to "bash" in every output.

Signed-off-by: BartyBoi1128 <[email protected]>
Copy link
Contributor

@myteron myteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old sentence still in there

Copy link
Contributor

@myteron myteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now

@noah-de
Copy link

noah-de commented Dec 16, 2024

Speaking with Helge this morning, we agreed that I will review this later today.

Copy link

@noah-de noah-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document reads well and the concepts are clearly conveyed. The examples are fitting and easy to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants