-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CWE 1339 #697
base: main
Are you sure you want to change the base?
CWE 1339 #697
Conversation
…ation Signed-off-by: ebakrra <[email protected]>
Added new noncomplian01.py Signed-off-by: BartyBoi1128 <[email protected]>
Added new compliant01.py Signed-off-by: BartyBoi1128 <[email protected]>
Added new compliant02.py Signed-off-by: BartyBoi1128 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some minor cosmetic fixes. Other than that it looks good.
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: myteron <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: myteron <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: myteron <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]> Signed-off-by: myteron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update main readme.md !
bunch of formatting and link issues
docs/Secure-Coding-Guide-for-Python/CWE-682/CWE-1339/noncompliant01.py
Outdated
Show resolved
Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-682/CWE-1339/compliant01.py
Outdated
Show resolved
Hide resolved
…ant01.py Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
…01.py Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Updated ISO/IEC reference link as previous looked like spam Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
…02.py Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
Updated output to "bash" and added blank line to please linter. Signed-off-by: BartyBoi1128 <[email protected]>
Updated output of "text" to "bash" in every output. Signed-off-by: BartyBoi1128 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old sentence still in there
Co-authored-by: myteron <[email protected]> Signed-off-by: BartyBoi1128 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good now
Speaking with Helge this morning, we agreed that I will review this later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document reads well and the concepts are clearly conveyed. The examples are fitting and easy to understand.
Documentation and code updates for CWE-1339 Insufficient Precision or Accuracy of a Real Number