Add contributor guidance (OSPS-DO-02) #124
Conversation
There was a problem hiding this comment.
@evankanderson you need to signoff on the commit before we can merge it.
(And so we should probably add that to this file as well)
Nevermind the above. I see that you added it, you just didn't follow it. 😄
Signed-off-by: Evan Anderson <[email protected]>
evankanderson
force-pushed
the
contributing
branch
from
1e6b325 to
23b6f72
Compare
... I was just checking, of course! 😉 Fixed. |
| All changes to the repository should be made via PR | ||
| ([OSPS-AC-03](https://baseline.openssf.org/#osps-ac-03)). In addition to a clear | ||
| title and descriptive commit message, PRs MUST meet the following criteria: | ||
|
|
||
| * DCO signoff (via `git commit -s` -- [OSPS-LE-01](https://baseline.openssf.org/#osps-le-01)) | ||
| * All checks must pass ([OSPS-QA-04](https://baseline.openssf.org/#osps-qa-04)) |
There was a problem hiding this comment.
We might want to leave the links out of this, since #113 will break them anyway. I think we're fine without the citations, but if you feel strongly about leaving them in, we should decide if we want to have them be hyperlinks or just bare text references.
There was a problem hiding this comment.
As "customer zero", we should figure out what the best practices are here. Linking to the criteria seems helpful in providing background information, but only if the URLs are stable enough that they don't just turn into dead links.
(And, I think that's something worth thinking about as we proceed...)
| All changes to the repository should be made via PR | ||
| ([OSPS-AC-03](https://baseline.openssf.org/#osps-ac-03)). In addition to a clear |
There was a problem hiding this comment.
| All changes to the repository should be made via PR | |
| ([OSPS-AC-03](https://baseline.openssf.org/#osps-ac-03)). In addition to a clear | |
| All changes to the repository should be made via a pull request (PR) | |
| (this enables us to meet our own requirement [OSPS-AC-03](https://baseline.openssf.org/#osps-ac-03)). | |
| In addition to a clear |
Per discussion on slack