-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: setup yaml linting of SBOM Catalog #73
Conversation
Signed-off-by: Ian Dunbar-Hall <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
d1925d3
to
8f8078f
Compare
Signed-off-by: Ian Dunbar-Hall <[email protected]>
8f8078f
to
078b956
Compare
@Mariuxdeangelo I'm adding some schema validation to In
I can easily update Thoughts if I update the interface to be ...
|
@idunbarh, thanks for pointing out the singular, plural thing. I will look into that, but you're right. All Plural would be best. It's also a great idea to add linting. I'm not 100 percent happy about adding some Python tooling to the NPM project, but it's only in the CI, so I think it's fine for now 👍. |
Mybe it would be a good convention to say lists are in plural and regular Strings are in singular. |
@Mariuxdeangelo sounds good. I'll go ahead and make the updates for the lists to be plural in the interface and in |
Hey @idunbarh, I just took the liberty to add your PR to mine and fix the data.yaml. I recently added some more projects, so I wanted to make sure that they also adhere to the schemas. |
Perfect! I'll add some additional tools once that PR is merged. I'll close this PR in the meantime. |
This PR adds yaml linting and schema validation to ensure contributions to the SBOM Catalog don't break the data and filter yaml files.